Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tst_put_vars.c and tst_elatefill.c are netCDF-4 only tests, and should be moved to nc_test4 from nc_test #738

Closed
edhartnett opened this issue Dec 22, 2017 · 5 comments

Comments

@edhartnett
Copy link
Contributor

These two tests are straight-up netCDF-4 tests. They were contributed by users who did not follow the convention of putting netCDF-4 only tests in nc_test4.

I will move them.

@wkliao
Copy link
Contributor

wkliao commented Dec 22, 2017

I think both test programs can be used to test classic file formats as well.
All you have to do is to add a loop of all formats on top.

@edhartnett
Copy link
Contributor Author

Yes, unfortunately the elatefill one will not work with classic at this time.

@wkliao
Copy link
Contributor

wkliao commented Dec 22, 2017

The fix for classic files is in #731

@edhartnett
Copy link
Contributor Author

OK, that's awesome! Thanks!

@edhartnett
Copy link
Contributor Author

Once I separated libsrc4 from libhdf5, these tests become an issue in this directory. When it is possible to build without hdf5, but with netCDF4 (and HDF4, or a user-defined format), these files become a configuration issue.

In HPC NetCDF I have moved them to the nc_test4 directory, and all the configuration problems go away. They can still be run on all formats, but since they are sometimes run on HDF5, they work best in nc_test4. nc_test is a good place for tests that never use HDF5.

I will put up a PR moving these tests. Also tst_atts.c and tst_diskless2.c need to be moved. tst_atts.c becomes nc_test4/tst_atts3.c.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants