We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
In /Users/gdsjaar/src/seacas-sems/TPL/netcdf/netcdf-c/oc2/ocnode.c
/Users/gdsjaar/src/seacas-sems/TPL/netcdf/netcdf-c/oc2/ocnode.c
static OCerror occorrelater(OCnode* dds, OCnode* dxd) { int i,j; OCerror ocstat = OC_NOERR; if(dds->octype != dxd->octype) { OCTHROWCHK((ocstat = OC_EINVAL)); goto fail; } if(dxd->name != NULL && dxd->name != NULL && strcmp(dxd->name,dds->name) != 0) { OCTHROWCHK((ocstat = OC_EINVAL)); goto fail; } else if(dxd->name != dxd->name) { /* test NULL==NULL */ OCTHROWCHK((ocstat = OC_EINVAL)); goto fail; } if(dxd->array.rank != dds->array.rank) { OCTHROWCHK((ocstat = OC_EINVAL)); goto fail; }
The second if/else if test is testing dxd against itself. I think it should be dxd vs dds:
dxd
dds
if(dds->name != NULL && dxd->name != NULL && strcmp(dxd->name,dds->name) != 0) { OCTHROWCHK((ocstat = OC_EINVAL)); goto fail; } else if(dds->name != dxd->name) { /* test NULL==NULL */ OCTHROWCHK((ocstat = OC_EINVAL)); goto fail; }
The text was updated successfully, but these errors were encountered:
I have made this change in my ejh_cleanup branch. It will be up for PR shortly.
Sorry, something went wrong.
Successfully merging a pull request may close this issue.
In
/Users/gdsjaar/src/seacas-sems/TPL/netcdf/netcdf-c/oc2/ocnode.c
The second if/else if test is testing
dxd
against itself. I think it should bedxd
vsdds
:The text was updated successfully, but these errors were encountered: