Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Investigate improvements to clean up complex indexing #912

Closed
dopplershift opened this issue Aug 2, 2018 · 0 comments · Fixed by #1260
Closed

Investigate improvements to clean up complex indexing #912

dopplershift opened this issue Aug 2, 2018 · 0 comments · Fixed by #1260
Labels
Area: Calc Pertains to calculations Area: Infrastructure Pertains to project infrastructure (e.g. CI, linting) Type: Enhancement Enhancement to existing functionality

Comments

@dopplershift
Copy link
Member

There are a lot of places where we assemble list of slices and whatnot in order to do complicated index operations. This code got a lot uglier in the process of clearing warnings for numpy 1.15 by putting a lot of calls to tuple() everywhere. At some point we should look at this stuff and see if there are better ways:

  • Better use of functions built into NumPy itself
  • Implement some kind of object in MetPy to encapsulate these things
  • Need to consider how this will play with XArray as we continue to move forward on that.
@dopplershift dopplershift added Area: Infrastructure Pertains to project infrastructure (e.g. CI, linting) Type: Enhancement Enhancement to existing functionality Area: Calc Pertains to calculations labels Aug 2, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area: Calc Pertains to calculations Area: Infrastructure Pertains to project infrastructure (e.g. CI, linting) Type: Enhancement Enhancement to existing functionality
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant