Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update NEXRAD Level2File for TDWR #1239

Closed
dopplershift opened this issue Nov 21, 2019 · 0 comments · Fixed by #1251
Closed

Update NEXRAD Level2File for TDWR #1239

dopplershift opened this issue Nov 21, 2019 · 0 comments · Fixed by #1251
Labels
Area: IO Pertains to reading data Type: Bug Something is not working like it should Type: Enhancement Enhancement to existing functionality
Milestone

Comments

@dopplershift
Copy link
Member

dopplershift commented Nov 21, 2019

NWS is planning to collect Level 2 data from TDWR's, using the a variant of the standard level 2 format. We need a few updates to handle this properly.

  1. Remove assertion checking radial length against the offset in _decode_msg31; at best this should be a warning, but I'm pretty sure it should just be debug output if anything
  2. Fix conditional decoding of versions of radial constant block. This should look at the encoded size of the block rather than using the volume version value.
  3. Fix warning on size of Message 2 format; again, should probably use encoded message size as check.

This sample file should decode with no warnings by default.

A few other things I noticed:

  1. We should remove all assertions from Level2File. None of the remaining ones look like conditions in which we will fail to walk through the messages in the file or do memory-exhausting tasks (due to bad sizes/offsets). These should just be log messages at the appropriate level
  2. When reading the pointers to the data blocks, we should be looking at the number of blocks/size of the data block header to determine what to read, not just read in a fixed size. Based on the ICD, some pointers may not even exist. Should probably run through some files to see what's going on in practice.
@dopplershift dopplershift added Area: IO Pertains to reading data Type: Bug Something is not working like it should Type: Enhancement Enhancement to existing functionality labels Nov 21, 2019
@dopplershift dopplershift added this to the 0.12 milestone Nov 21, 2019
@dopplershift dopplershift mentioned this issue Dec 21, 2019
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area: IO Pertains to reading data Type: Bug Something is not working like it should Type: Enhancement Enhancement to existing functionality
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant