-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add VSCode configuration setting for default Unibeautify configuration file #55
Comments
The best practice would be to include your configuration in the same VSCode project/workspace.
This could be your This is currently supported by ---
PHP: # Language
beautifiers: # Enable beautifiers
- PHP-CS-Fixer
PHP-CS-Fixer:
prefer_beautifier_config: true https://github.com/Unibeautify/beautifier-php-cs-fixer/blob/master/src/index.ts#L77 For example, If you could provide more details on your use case, we can help more 😃 . |
We can reopen if you have more questions 😃 . |
Hm I know what you mean by symlinking them, I already do it like this, but I really don‘t want to symlink all my confs in every project every time. It would be way smoother to specify the path to the conf in the {
"PHP": {
"beautifiers": ["PHP-CS-Fixer"],
"prefer_beautifier_config": "/Users/marvinheilemann/Dropbox/Configs/.php_cs"
}
} and another idea would be to have one |
Unibeautify is optimized for the conventional workflow where project's configuration is contained in the same project directory.
Absolute paths are also usually a bad idea within projects because they are not portable. This is also why
I think this would be acceptable. 😃 Especially when we considering cases where a project does not have a Unibeautify configuration at all you want it to fallback. @muuvmuuv would you be interested in adding support for |
I got what you mean, I will work with symlinks now ^^ anyway it would be cool (I don't share the most of my projects) For the other thing, I‘ll have a look. I don‘t have much time the next month, but It seems like a little update to the code. |
Let me know if / before you start working on it. I might be able to implement this feature if I have some time this weekend, since it is small. Usually though, I have other higher priority tasks to work on so I would expect open-source contributors to make a Pull Request 😄. |
@Glavin001 started already 😁 |
Awesome! 🎉 Let me know if you have any questions. |
Was this closed by #57? |
@szeck87 yes Sent with GitHawk |
I have several of my configurations in my Dropbox folder and want to link to them from UB. That would be very nice!
Update: Add support for
unibeautify.defaultConfig
(type:string
) configuration option which points to a.unibeautifyrc
config file? This would likely require a change to: https://github.com/Unibeautify/vscode/blob/master/src/EditProvider.ts#L105-L109Also see https://code.visualstudio.com/docs/extensionAPI/extension-points#_contributesconfiguration
Please let me know if you have any questions!
The text was updated successfully, but these errors were encountered: