Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

3.1.1 tag version miss match #25

Closed
UndefinedOffset opened this issue Aug 4, 2016 · 1 comment
Closed

3.1.1 tag version miss match #25

UndefinedOffset opened this issue Aug 4, 2016 · 1 comment
Labels
Milestone

Comments

@UndefinedOffset
Copy link
Owner

UndefinedOffset commented Aug 4, 2016

Due to how git works and packagist works when the 3.1.1 tag was created the date packagist puts in the composer.lock is the date of commit fa0bfad. Which is causing the desktop client to report a version miss match when Code Bank is installed via composer. There's two hacky fixes for this, but we really should do a new release:

Updating CodeBank/_config.php by replacing the constants on lines 2 & 3:

define('CB_BUILD_DATE', '20160730');
define('CB_VERSION', '3.1.1');

Modifying composer.lock by searching for the "name": "undefinedoffset/silverstripe-codebank" line and changing the next instance of "time": "2016-03-23 12:36:50" to:

"time": "2016-07-30 12:36:50"
@UndefinedOffset UndefinedOffset modified the milestone: 3.1.2 Aug 4, 2016
@UndefinedOffset
Copy link
Owner Author

3.1.2 has been released please update

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant