New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Two versions of RenderMode, usage and actual implementation differ... #82

Open

daid opened this issue Dec 15, 2015 · 0 comments

Labels

Contributor

daid commented Dec 15, 2015

There are two versions of RenderModes, that use different values:
https://github.com/Ultimaker/Uranium/blob/master/UM/View/Renderer.py#L14
https://github.com/Ultimaker/Uranium/blob/master/UM/View/RenderBatch.py#L34

renderer.queueNode() in Cura uses the Renderer one:
https://github.com/Ultimaker/Cura/blob/master/plugins/SolidView/SolidView.py#L61

However, the implementation acts as the one RenderBatch version.

I think the Renderer version can just be removed. But didn't want to break anything.

Ghostkeeper added the enhancement label

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment