Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"Reload All Models" only reloads one model #19031

Closed
gsangermano opened this issue May 6, 2024 · 12 comments
Closed

"Reload All Models" only reloads one model #19031

gsangermano opened this issue May 6, 2024 · 12 comments
Labels
Status: On Backlog The issue / feature has been reproduced and is deemed important enough to be fixed. Type: Bug The code does not produce the intended behavior.

Comments

@gsangermano
Copy link

Cura Version

5.7.1

Operating System

Windows 11

Printer

Creality Ender 3 Pro

Reproduction steps

  1. Load a model
  2. Right click on the model and select "Multiply Selected" and make 3 copies
  3. In another program, save an updated version of the model. Or in the file system, delete the model and rename another to have the same name.
  4. In Cura, from the "File" menu select "Reload All Models"

Actual results

Only 1 model is updated.

Expected results

All 4 models are updated.

Add your .zip and screenshots here ⬇️

Screenshot

@gsangermano gsangermano added Status: Triage This ticket requires input from someone of the Cura team Type: Bug The code does not produce the intended behavior. labels May 6, 2024
@GregValiant GregValiant added Status: Under Investigation The issue has been confirmed or is assumed to be likely to be a real issue. It's pending discussion. and removed Status: Triage This ticket requires input from someone of the Cura team labels May 6, 2024
@GregValiant
Copy link
Collaborator

Thanks for the report.
It appears (to me) that when you multiply the model and Cura assigns a unique name to each copy by appending "(nr)" to each name, that only the model with the original name ("x.stl" in your project) is acknowledged as being the same model. So x.stl(1), x.stl(2), etc. don't get altered in the Cura scene because of the different name. I think that makes sense, but whether or not that is actually what's happening might be incorrect.

Someone from the Cura team will take a look.

@HellAholic
Copy link
Contributor

When you multiply or duplicate a model, it creates a copy at that exact moment with all the per model settings. However, the newly generated copies don't have any reference to the original STL that was opened, so changing the original STL will not affect them when reloading all models since they only inherited from the original at the moment of being copied.
I understand what you're trying to do here but using the multiply as a template system is not part of the multiply function so
I suggest changing this to a feature request as that seems more in line.

@gsangermano
Copy link
Author

What you guys are saying makes sense except for one thing: this used to work. I've done this literally dozens of times in the past.

@HellAholic
Copy link
Contributor

HellAholic commented May 10, 2024

@gsangermano I'll add a ticket for investigation.

Internal reference: CURA-11905

@katyo
Copy link

katyo commented Sep 20, 2024

I have same issue with 5.8.1

@GregValiant
Copy link
Collaborator

This did work as described (all models updated) in 4.13.1. Checking 5.8.0 only the original model updates.
4.13.1
image

5.8.0 Only the original model (in the middle) updates.
image

@HellAholic
Copy link
Contributor

HellAholic commented Sep 20, 2024

@GregValiant Tracked the issue to switch between 5.6 to 5.7
Originally the assumption was the change we did to add the copy paste function (Cura 5.5). But my guestimate is the Qt upgrade that we were obligated to do in order to comply with the openssl security requirements.
If it's a highly used feature, I can push for the priority to increase, but if the source of the issue is in the Qt, then it would be super messy.

@GregValiant
Copy link
Collaborator

Well messy sucks as it often leads to what we already have here and that is an "Unexpected Consequence".

Updating all the models is important to professional designers/technicians.
They lay out their build plate with multiple copies of a model, look at the slice, and realize that if they make a minor tweak to the model the slice will result in a better print, less supports required, better orientation ... whatever.
So they reload the model and only the initial model updates. Unfortunately, they have added Support Blockers to all the models and also unfortunately, those blockers are linked to the individual models which now need to be deleted. They have to re-do the entire build plate (except for the original) for what was a minor change to the model. That's a serious hit time-wise, and time is money. A real downside is that if it is a very minor change to the model, and it is internal, that some users may not know that the copies did not update. That's a bad situation.

Whether it's messy or not, I would advise to bump this up. I know a lot of development is driven by the kids printing mini's and dnd characters. The high-end users need some love sometimes too. They are the ones most likely to be UM customers, or future UM customers.

@HellAholic HellAholic added Status: On Backlog The issue / feature has been reproduced and is deemed important enough to be fixed. and removed Status: Under Investigation The issue has been confirmed or is assumed to be likely to be a real issue. It's pending discussion. labels Sep 24, 2024
@yet-another-average-joe

Some news about this major bug ?
It makes Cura unusable when iterating and printing series of pieces.

@HellAholic
Copy link
Contributor

Fixed with:
#19721
Ultimaker/Uranium#971

@GregValiant
Copy link
Collaborator

@HellAholic,
These bug reports seem to be related to this. Can these also be closed?
#18421
#11557
#10137
#15641

@gsangermano
Copy link
Author

Bad news. I just downloaded the 5.9.0 and this bug is NOT fixed (actually it's half fixed).

If you look at step 3 in my original steps to reproduce, the first case works. That's were you save a new version of your file into the old version. But not the second case where you delete the file, rename a different file to the same name and do File \ Reload All Models. Only the original model is loaded with the new one.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Status: On Backlog The issue / feature has been reproduced and is deemed important enough to be fixed. Type: Bug The code does not produce the intended behavior.
Projects
None yet
Development

No branches or pull requests

5 participants