Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix close button disappearing on scroll #211

Merged
merged 1 commit into from
Oct 19, 2023
Merged

Fix close button disappearing on scroll #211

merged 1 commit into from
Oct 19, 2023

Conversation

masiulis
Copy link
Contributor

Close button should be positioned fixed from screen, not absolute from parent. This behaviour can be overridden in a standard way with theme closeModalButton style.

@masiulis masiulis added the fix Fixes a bug label Oct 19, 2023
@masiulis masiulis merged commit 14167c4 into master Oct 19, 2023
5 checks passed
@masiulis masiulis deleted the UGN-408 branch October 19, 2023 15:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
fix Fixes a bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants