Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Players Don't Drop Coins When Smashed By Maelstrom #195

Closed
TheNexusAvenger opened this issue Feb 16, 2021 · 0 comments · Fixed by #207
Closed

Players Don't Drop Coins When Smashed By Maelstrom #195

TheNexusAvenger opened this issue Feb 16, 2021 · 0 comments · Fixed by #207
Assignees
Labels
affects: gameplay Related to gameplay type: bug Something isn't working

Comments

@TheNexusAvenger
Copy link
Member

When you smash yourself, such as by using the smash command, you drop coins that you can try to re-collect. This behavior should exist for players being killed by Maelstrom, and does exist in the code, but doesn't function as intended. The causes appears to be GeneratePlayerYieldsAsync being passed null for the player, which is from SmashAsync checking if the smashed object is a Player, and then passing owner, which can be undefined, instead of (Player) GameObject.

@TheNexusAvenger TheNexusAvenger changed the title Players Don't Drop Coins When Smashed Players Don't Drop Coins When Smashed By Maelstrom Feb 16, 2021
@TheNexusAvenger TheNexusAvenger added type: bug Something isn't working affects: gameplay Related to gameplay labels Feb 16, 2021
@TheNexusAvenger TheNexusAvenger self-assigned this Feb 19, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
affects: gameplay Related to gameplay type: bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant