Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cmakelists with boost not found #552

Closed
xiefangping opened this issue Mar 12, 2019 · 2 comments
Closed

cmakelists with boost not found #552

xiefangping opened this issue Mar 12, 2019 · 2 comments

Comments

@xiefangping
Copy link

In your cmakelists, even if boost not found, still unittest and sandbox will be built, which cause a problem.

# Boost serialization for performance sandbox
find_package(Boost COMPONENTS serialization)

if(Boost_FOUND)
  include_directories(SYSTEM ${Boost_INCLUDE_DIRS})
endif(Boost_FOUND)
  
enable_testing()
add_subdirectory(unittests)

add_subdirectory(sandbox)
@AzothAmmo
Copy link
Contributor

The unit tests do not use boost, and the portions of sandbox that require boost are already guarded: https://github.com/USCiLab/cereal/blob/develop/sandbox/CMakeLists.txt

@AzothAmmo
Copy link
Contributor

This should be fixed now in the sense that the boost unit test (variadic) is now behind Boost_FOUND. See #568

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants