Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cmake support / interface library commits are broken #254

Closed
tamaskenez opened this issue Dec 27, 2015 · 2 comments
Closed

cmake support / interface library commits are broken #254

tamaskenez opened this issue Dec 27, 2015 · 2 comments
Milestone

Comments

@tamaskenez
Copy link

The commit 7b10a08 (resolves #222) adds a CMake INTERFACE library which breaks the build for older CMake versions.
The commit 1ef6415 tries to fix this but it's still wrong. The INTERFACE library has been introduced in CMake 3.0.

I'd like to draw your attention to PR #239 which solves this and other, related issues and still runs correctly with older CMake versions. I suggest you to revert 1ef6415 and 7b10a08 and merge #239 instead.
#239 has been in the queue for almost 3 months. I guess you had some problems with it, that's why you merged 7b10a08 instead. Please let me know how to improve #239 if that's the case.

@AzothAmmo
Copy link
Contributor

I don't think there is any problem with #239, I just missed it when I was organizing things recently - I'll revert and take it instead.

@AzothAmmo AzothAmmo added this to the v1.2.0 milestone Dec 28, 2015
@AzothAmmo
Copy link
Contributor

merged #239

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants