Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(bug): fix Riccobug #19

Closed
wants to merge 2 commits into from
Closed

fix(bug): fix Riccobug #19

wants to merge 2 commits into from

Conversation

drendog
Copy link
Contributor

@drendog drendog commented Oct 3, 2020

Closes #18

fix Riccobug: if the content of the news changes, you will not be able to receive the new news
@drendog drendog requested a review from Helias October 3, 2020 11:52
@Helias
Copy link
Member

Helias commented Oct 3, 2020

Prima di mergiare, preferirei tenere un UNICT bot con la tua PR integrata online prima che esploda qualcosa

Se per caos la tua PR dovesse, in qualche modo, visualizzare "sempre diverso" il riassunto di una news e si intaserebbe.
UNICT Bot gestisce troppi canali per verificare che tutto va bene e per rischiare che esploda qualcosa, quindi ti chiederei di
hostare un UNICT Bot dev che pubblica tutti i post su un canale di test e vediamo se si inceppa o meno.

Oppure vediamo cosa dice @aegroto a riguardo e ci prendiamo il rischio di mettere online questa modifica.

@Helias Helias requested a review from aegroto October 3, 2020 11:57
module/scraper_notices.py Outdated Show resolved Hide resolved
module/scraper_notices.py Outdated Show resolved Hide resolved
module/scraper_notices.py Outdated Show resolved Hide resolved
module/scraper_notices.py Show resolved Hide resolved
module/scraper_notices.py Show resolved Hide resolved
module/scraper_notices.py Show resolved Hide resolved
@aegroto
Copy link
Member

aegroto commented Oct 3, 2020

Il bug che la PR cerca di risolvere in cosa consiste?

@Helias
Copy link
Member

Helias commented Oct 17, 2020

@drendog

@drendog
Copy link
Contributor Author

drendog commented Oct 17, 2020

@Helias domani vedrò di sistemare, per il testing non so cosa possiamo fare

@drendog drendog requested a review from Helias October 18, 2020 15:28
@drendog
Copy link
Contributor Author

drendog commented Oct 19, 2020

Direi di non mergiare per adesso. Sto provando ad adattare il bot con le gh actions in un branch provvisorio, così da poter testare le modifiche di questa pull.

@drendog drendog marked this pull request as draft October 19, 2020 10:15
@drendog drendog marked this pull request as ready for review October 20, 2020 08:42
@drendog
Copy link
Contributor Author

drendog commented Oct 20, 2020

sto testando queste modifiche tramite il bot adattato con le gh actions che aggiorna le news di tutti i dipartimenti supportati ogni 15 minuti, https://t.me/unicheattibot

@Herbrant
Copy link
Member

Il bot è ancora affetto da questo bug? Ha senso tenere questa PR aperta?

@drendog
Copy link
Contributor Author

drendog commented Mar 27, 2021

si

@Herbrant
Copy link
Member

Qualcuno ha testato la PR? Ad ogni modo vanno risolti i conflitti.

@Helias
Copy link
Member

Helias commented Nov 12, 2022

merge conflicts, after that I could try to test it

@drendog
Copy link
Contributor Author

drendog commented Nov 12, 2022

i will open another PR for this

@drendog drendog closed this Nov 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Riccobug
4 participants