-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(EMS-1693): Application submission - XLSX - dynamic section title row indexes #515
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…cept usingBroker argument
…ow indexes dynamically
Zainzzkk
previously approved these changes
Jun 5, 2023
Kudos, SonarCloud Quality Gate passed! 0 Bugs No Coverage information |
Zainzzkk
approved these changes
Jun 5, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates the config/generation for the XLSX file we send to the underwriting team. This fixes an issue where certain section titles in the XLSX file would be styled incorrectly. This was because we were not accounting for different application states, depending on the submitted answers - we now get the XLSX section title row indexes dynamically depending on the submitted answers:
If any one of these conditions is true, all the proceeding row indexes change because there are new rows.
Changes
XLSX_CONFIG
API constants to:Other improvements
completeAndSubmitBrokerForm
cypress command to accept ausingBroker
flag/param and then complete/submit the form appropriately.completeSignInAndSubmitAnApplication
to accept apolicyType
flag/param and then complete/submit the "prepare application" sections appropriately.ANSWERS
API constants andpolicyType
helper function.LARGE_ADDITIONAL_COLUMN_HEIGHT
.