Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(EMS-1662): Account password reset - reset auth retries #499

Merged
merged 3 commits into from
May 25, 2023
Merged

feat(EMS-1662): Account password reset - reset auth retries #499

merged 3 commits into from
May 25, 2023

Conversation

ttbarnes
Copy link
Contributor

This PR updates the account password reset GQL resolver to reset the account's authentication retry entries.

Changes

  • Update account password reset GQL resolver to call deleteAuthenticationRetries helper function.
  • Fixed some typos.
  • Added missing test coverage for getAuthenticationRetriesByAccountId helper function.

@ttbarnes ttbarnes added enhancement New feature or request tech Technical debt/improvements labels May 25, 2023
@ttbarnes ttbarnes self-assigned this May 25, 2023
@ttbarnes ttbarnes temporarily deployed to qa May 25, 2023 12:03 — with GitHub Actions Inactive
@ttbarnes ttbarnes temporarily deployed to qa May 25, 2023 12:03 — with GitHub Actions Inactive
@ttbarnes ttbarnes temporarily deployed to qa May 25, 2023 12:46 — with GitHub Actions Inactive
@ttbarnes ttbarnes temporarily deployed to qa May 25, 2023 12:46 — with GitHub Actions Inactive
@ttbarnes ttbarnes temporarily deployed to qa May 25, 2023 12:46 — with GitHub Actions Inactive
@ttbarnes ttbarnes temporarily deployed to qa May 25, 2023 12:46 — with GitHub Actions Inactive
@ttbarnes ttbarnes temporarily deployed to qa May 25, 2023 12:46 — with GitHub Actions Inactive
@ttbarnes ttbarnes temporarily deployed to qa May 25, 2023 12:46 — with GitHub Actions Inactive
@ttbarnes ttbarnes temporarily deployed to qa May 25, 2023 12:46 — with GitHub Actions Inactive
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@ttbarnes ttbarnes requested a review from Zainzzkk May 25, 2023 13:48
@ttbarnes ttbarnes merged commit bee168a into main-application May 25, 2023
@ttbarnes ttbarnes deleted the feat/EMS-1662 branch May 25, 2023 13:56
@github-actions github-actions bot mentioned this pull request Jul 7, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Zainzzkk Zainzzkk Zainzzkk approved these changes

Assignees

@ttbarnes ttbarnes

Labels
enhancement New feature or request tech Technical debt/improvements
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ttbarnes @Zainzzkk