Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(EMS-3826-3829): export contract - agent charges - user flow #3098

Merged
merged 14 commits into from
Sep 20, 2024

Conversation

ttbarnes
Copy link
Contributor

@ttbarnes ttbarnes commented Sep 19, 2024

Introduction ✏️

This PR updates the "Export contract - agent charges" flow so that it is the same as design:

  1. Agent charges form.
  2. If FIXED_SUM - Agent charges currency form.
  3. Agent FIXED_SUM_AMOUNT form.
  4. Check your answers.

Resolution ✔️

  • Update E2E tests, commands.
  • Update UI POST redirects.
  • Remove check/change redirect and alternativeCurrencyUrl logic from AGENT_CHARGES controllers.
  • Remove invalid redirects from AGENT_CHARGES_CURRENCY POST controller.

Miscellaneous ➕

  • Remove old/unused validation rules.
  • Fix a typo.
  • Update the HOW_MUCH_IS_THE_AGENT_CHARGING nunjucks template to render a hint.

@ttbarnes ttbarnes added enhancement New feature or request feature New functionality chore Chore labels Sep 19, 2024
@ttbarnes ttbarnes self-assigned this Sep 19, 2024
Base automatically changed from feat/EMS-3829 to main-iterations September 20, 2024 10:52
@ttbarnes ttbarnes merged commit be6a35a into main-iterations Sep 20, 2024
179 of 181 checks passed
@ttbarnes ttbarnes deleted the feat/EMS-3826-3829 branch September 20, 2024 14:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore Chore enhancement New feature or request feature New functionality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants