Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(EMS-3234): no PDF - Export contract - Fixed sum amount - decimal number data saving #2653

Merged
merged 4 commits into from
Jul 2, 2024
Merged

fix(EMS-3234): no PDF - Export contract - Fixed sum amount - decimal number data saving #2653

merged 4 commits into from
Jul 2, 2024

Conversation

Zainzzkk
Copy link
Collaborator

@Zainzzkk Zainzzkk commented Jul 2, 2024 •
edited by ttbarnes
Loading

Introduction ✏️

This PR fixes an issue where data saving did not work for fixed sum amount as it was a decimal number

Resolution ✔️

  • Changed schema to decimal type for fixedSumAmount
  • Updated sql file to decimal for fixed sum amount
  • Added transformEmptyDecimalsToWholeNumber helper to remove .00 from number
  • Update application mapping
  • Updated test
  • Added e2e test

Miscellaneous ➕

  • Rename decimalPoints instances to decimalPlaces

@Zainzzkk Zainzzkk added the fix Fixes an existing issue label Jul 2, 2024
@Zainzzkk Zainzzkk self-assigned this Jul 2, 2024
@Zainzzkk Zainzzkk requested a deployment to qa July 2, 2024 14:57 — with GitHub Actions Abandoned
@Zainzzkk Zainzzkk requested a deployment to qa July 2, 2024 14:57 — with GitHub Actions Abandoned
@Zainzzkk Zainzzkk requested a deployment to qa July 2, 2024 14:57 — with GitHub Actions Abandoned
@Zainzzkk Zainzzkk requested a deployment to qa July 2, 2024 14:57 — with GitHub Actions Abandoned
@Zainzzkk Zainzzkk requested a deployment to qa July 2, 2024 14:57 — with GitHub Actions Abandoned
@Zainzzkk Zainzzkk requested a deployment to qa July 2, 2024 14:57 — with GitHub Actions Abandoned
@Zainzzkk Zainzzkk requested a deployment to qa July 2, 2024 14:57 — with GitHub Actions Abandoned
@Zainzzkk Zainzzkk requested a deployment to qa July 2, 2024 14:57 — with GitHub Actions Abandoned
@Zainzzkk Zainzzkk requested a deployment to qa July 2, 2024 14:57 — with GitHub Actions Abandoned
@Zainzzkk Zainzzkk requested a deployment to qa July 2, 2024 14:57 — with GitHub Actions Abandoned
@Zainzzkk Zainzzkk requested a deployment to qa July 2, 2024 14:57 — with GitHub Actions Abandoned
@Zainzzkk Zainzzkk requested a deployment to qa July 2, 2024 14:57 — with GitHub Actions Abandoned
@Zainzzkk Zainzzkk requested a deployment to qa July 2, 2024 14:57 — with GitHub Actions Abandoned
@Zainzzkk Zainzzkk requested a deployment to qa July 2, 2024 14:57 — with GitHub Actions Abandoned
@Zainzzkk Zainzzkk requested a deployment to qa July 2, 2024 14:57 — with GitHub Actions Abandoned
@Zainzzkk Zainzzkk requested a deployment to qa July 2, 2024 14:57 — with GitHub Actions Abandoned
@Zainzzkk Zainzzkk requested a deployment to qa July 2, 2024 14:57 — with GitHub Actions Abandoned
@Zainzzkk Zainzzkk requested a deployment to qa July 2, 2024 14:57 — with GitHub Actions Abandoned
@Zainzzkk Zainzzkk requested a deployment to qa July 2, 2024 14:57 — with GitHub Actions Abandoned
@Zainzzkk Zainzzkk requested a deployment to qa July 2, 2024 14:57 — with GitHub Actions Abandoned
@Zainzzkk Zainzzkk requested a deployment to qa July 2, 2024 14:57 — with GitHub Actions Abandoned
@Zainzzkk Zainzzkk requested a deployment to qa July 2, 2024 14:57 — with GitHub Actions Abandoned
@ttbarnes ttbarnes merged commit 8ae5ba9 into main-application-no-pdf Jul 2, 2024
167 checks passed
@ttbarnes ttbarnes deleted the fix/EMS-3234 branch July 2, 2024 15:48
@abhi-markan abhi-markan mentioned this pull request Jul 12, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ttbarnes ttbarnes ttbarnes approved these changes

Assignees

@Zainzzkk Zainzzkk

Labels
fix Fixes an existing issue
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Zainzzkk @ttbarnes