chore(EMS-662): update README.md #180
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
abhi-markan
previously approved these changes
Dec 8, 2022
There was a problem hiding this comment.
👍🏼 LGTM
Good effort @ttbarnes for an improved documentation, once I have finished all CI/CD and IaC tickets I will use the similar template and will update accordingly.
Well done.
|
Thanks @abhi-markan most appreciated - especially useful for new starters 😊 Sounds great re CI/CD/IaC. Found a couple of typos with fresh eyes, will fix asap. Also ideally would like @Zainzzkk and @IgnatG eyes on this before merging 🙏 |
Zainzzkk
reviewed
Dec 9, 2022
Zainzzkk
reviewed
Dec 9, 2022
|
Kudos, SonarCloud Quality Gate passed!
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds more details about EXIP, the code structure/approach and some development principles.
Link to the markdown generation for easier reading: https://github.com/UK-Export-Finance/exip/blob/603970f99be82a24c6dff4fb120fa35dd940ae2e/README.md