Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(EMS-382): cookies page updates for optional/analytics cookies #119

Merged
merged 20 commits into from
Oct 10, 2022

Conversation

ttbarnes
Copy link
Contributor

@ttbarnes ttbarnes commented Oct 6, 2022

Summary

This PR adds "optional cookies" copy and ability to change consent in the Cookies page.

Changes

  • Add accept/reject form to the Cookies page.
  • On cookies page GET, store the previous url in req.flash so that the cookie success banner can refer to the previous page if the form is submitted without selecting an answer.
  • Update cookies-banner script to listen to "change cookies" submit button (in the cookies page), and change cookie accordingly.
  • Splits up E2E test helpers/commands for cookie related assertions.
  • E2E tests.

Technical improvements

  • Cleaned up path descriptions for quote controller unit tests
  • Cleaned up controller/root structure for cookies and cookies-consent.

@ttbarnes ttbarnes added enhancement New feature or request feature New functionality labels Oct 6, 2022
@ttbarnes ttbarnes marked this pull request as ready for review October 6, 2022 12:25
@ttbarnes ttbarnes temporarily deployed to dev October 10, 2022 08:40 Inactive
@ttbarnes ttbarnes temporarily deployed to dev October 10, 2022 08:40 Inactive
@ttbarnes ttbarnes temporarily deployed to dev October 10, 2022 09:35 Inactive
@ttbarnes ttbarnes temporarily deployed to dev October 10, 2022 09:35 Inactive
@ttbarnes ttbarnes temporarily deployed to dev October 10, 2022 09:35 Inactive
@ttbarnes ttbarnes temporarily deployed to dev October 10, 2022 09:35 Inactive
@sonarqubecloud
Copy link

SonarCloud Quality Gate failed.    Quality Gate failed

Bug C 1 Bug
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 17 Code Smells

No Coverage information No Coverage information
22.6% 22.6% Duplication

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request feature New functionality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant