docs(playground): fix typo #2
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
adrian-bobev
approved these changes
Feb 11, 2019
ilhan007
added a commit
that referenced
this pull request
Aug 5, 2019
ilhan007
added a commit
that referenced
this pull request
Aug 12, 2019
ilhan007
added a commit
that referenced
this pull request
Jun 9, 2021
Introduce a dedicated component SuggestionGroupItem to split the suggestions into groups. Previously the app developers had to use the standard SuggestionItem and set its "group" property. But, as the group item do not have most of the interactive features, we decided to introduce dedicated component for the purpose. Related to: #3107 BREAKING_CHANGE: The "group" property of the SuggestionItem is removed, use the SuggestionGroupItem component to create grouping as follows: ```html <ui5-input show-suggestions> <ui5-suggestion-group-item text="Group #1"></ui5-suggestion-group-item> <ui5-suggestion-item text="Item #1"></ui5-suggestion-item> <ui5-suggestion-item text="Item #2"></ui5-suggestion-item> </ui5-input> ```
4 tasks
1 task
1 task
1 task
1 task
dobrinyonkov
added a commit
that referenced
this pull request
Sep 5, 2025
Fixes: #11687 ## Description Refactors the List component's scroll growing functionality to use intersection observers with start/end markers instead of unreliable scroll height calculations and scroll container detection. ## Background Problems The existing scroll growing implementation had several issues: - **Issue #10442 False positive load-more events during rerender/content changes - **Issue #11687 Failed detection when List is inside external scrollable containers - **Issue #11461 Firefox issue solved by the new implementation as well ## Solution Replaces the previous approach with: - **Start marker**: `<span>` element positioned at the beginning of the scroll container to track when user has scrolled down - **End marker**: `<span>` element positioned at the end to trigger load-more events - **Viewport-based intersection observers**: Two dedicated observers that detect marker visibility relative to the viewport - **State management**: `_startMarkerOutOfView` property to ensure container was scrolled down ## Test Coverage - DOM presence tests for start/end markers - Intersection observer functionality validation - **Edge case #1**: Rerender scenarios that previously caused false events - **Edge case #2**: External scrollable containers that previously failed detection
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.