-
Notifications
You must be signed in to change notification settings - Fork 278
fix(ui5-shellbar): ensure avatar click event is triggered correctly #12055
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(ui5-shellbar): ensure avatar click event is triggered correctly #12055
Conversation
- removed redundant new lines
I suggest to try and solve this via CSS. The shell bar is setting pointer-events: none to the avatar, which is part of the problem. The second part is the focus styles of the button, placing an absolute container over the content of the button "stealing" the pointer events. Perhaps, is better to set pointer events there instead. |
- fixed review comments
I made the solution CSS pointer event based as discussed, and moved the test to the Shellbar cypress file to avoid parasitic import in the Avatar cypress file. |
- try fixing failing spec file
Fixes: #11920