Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MacOS tests on Azure fail #64

Closed
KrisThielemans opened this issue Aug 20, 2020 · 6 comments
Closed

MacOS tests on Azure fail #64

KrisThielemans opened this issue Aug 20, 2020 · 6 comments

Comments

@KrisThielemans
Copy link
Collaborator

Errors like

/Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/../include/c++/v1/cmath:317:9: error: no member named 'signbit' in the global namespace
using ::signbit;

Also seen in many other places, including UCL/STIR#531 (comment)_
with hints it's a VTK bug

@KrisThielemans
Copy link
Collaborator Author

some people suggest to include <cmath> first, before anything else. e.g. https://developer.apple.com/forums/thread/110594?answerId=338792022#338792022

@KrisThielemans
Copy link
Collaborator Author

Note however that the Azure pipeline for OSX uses ITK 5.1 (see here, which will fail due to #55

@KrisThielemans KrisThielemans changed the title MacOS tests fail MacOS tests on Azure fail May 29, 2021
@KrisThielemans
Copy link
Collaborator Author

Clarification: errors occur on the azure pipeline where we use brew install itk. There is no problem on the Travis builds, where we install ITK ourselves.

Hopefully it will disappear when brew uses ITK 5.2.0.

@KrisThielemans
Copy link
Collaborator Author

Current errors (brew install ITK 5.1) also include https://dev.azure.com/petpvc/petpvc/_build/results?buildId=26&view=logs&j=a5e52b91-c83f-5429-4a68-c246fc63a4f7&t=2dac33d1-b0ca-5feb-3c36-18b56319df50&l=766

/usr/local/include/ITK-5.1/itkMath.h:326:32: error: expected unqualified-id
  if (std::signbit(x1) != std::signbit(x2))
                               ^
/Library/Developer/CommandLineTools/SDKs/MacOSX10.15.sdk/usr/include/math.h:170:5: note: expanded from macro 'signbit'
    ( sizeof(x) == sizeof(float)  ? __inline_signbitf((float)(x))

@KrisThielemans KrisThielemans linked a pull request Nov 15, 2022 that will close this issue
@KrisThielemans KrisThielemans removed a link to a pull request Nov 17, 2022
@KrisThielemans
Copy link
Collaborator Author

KrisThielemans commented Nov 17, 2022

There were 2 problems:

This 2 fixes are in 90a3150.

Hopefully, someone will fix the ITK version of brew at some point, but at least our CI is now fine.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant