-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Typhoid vignette #21
Typhoid vignette #21
Conversation
…population-based data.
@d-morrison Uh oh checks are failing now. Did I use an older version before your fixes? |
The relevant error is:
The |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
(see my reply re: check errors)
@d-morrison I removed |
@kristinawlai Looks like there is a reference to the "seroincidence" package somewhere: in the checks, there is a message:
|
possible fix for typhoid vignette
Merge branch 'typhoid_vignette' of https://github.com/UCD-SERG/serocalculator into typhoid_vignette # Conflicts: # man/incidence.age.Rd
@d-morrison the checks pass now! This is the only warning I saw when checking on my desktop and I'm not quite sure what to do with it. Maybe just a function name issue?
|
…lculator into typhoid_vignette
Closing this since all updates were moved to the typhoid_vignette_hack branch |
I finished the typhoid vignette withe the simulated data and moved the references.bib to the vignettes folder. However, Kristen recommended using the South Sudan data for this vignette so it's real data. The simulated data doesn't have age groups, so it's just overall incidence. I can make those updates, but wanted to get this version pushed out first to have something. Would it be useful to have an overall vignette and an age-specific vignette? Or perhaps include both in the same vignette?