diff --git a/.github/workflows/test-coverage.yaml b/.github/workflows/test-coverage.yaml index 45e8c147..e050312f 100644 --- a/.github/workflows/test-coverage.yaml +++ b/.github/workflows/test-coverage.yaml @@ -39,7 +39,8 @@ jobs: - uses: codecov/codecov-action@v4 with: - fail_ci_if_error: ${{ github.event_name != 'pull_request' && true || false }} + # Fail if error if not on PR, or if on PR and token is given + fail_ci_if_error: ${{ github.event_name != 'pull_request' || secrets.CODECOV_TOKEN }} file: ./cobertura.xml plugin: noop disable_search: true diff --git a/NEWS.md b/NEWS.md index 3dd4010c..ca5c2853 100644 --- a/NEWS.md +++ b/NEWS.md @@ -32,6 +32,9 @@ (from ) (#265) ## Internal changes + +* Updated `test-coverage.yml` GHA action to current `r-lib` standard (#330) + * Change default pipe setting (#312) * Add test for missing strata in `est.incidence.by` (#227) diff --git a/README.md b/README.md index 293a0d28..c58a1700 100644 --- a/README.md +++ b/README.md @@ -8,7 +8,8 @@ [![R-CMD-check](https://github.com/UCD-SERG/serocalculator/actions/workflows/R-CMD-check.yaml/badge.svg)](https://github.com/UCD-SERG/serocalculator/actions/workflows/R-CMD-check.yaml) -[![codecov](https://codecov.io/gh/UCD-SERG/serocalculator/graph/badge.svg?token=85CXV6GN2T)](https://codecov.io/gh/UCD-SERG/serocalculator) +[![Codecov test +coverage](https://codecov.io/gh/UCD-SERG/serocalculator/graph/badge.svg)](https://app.codecov.io/gh/UCD-SERG/serocalculator)
diff --git a/README.qmd b/README.qmd index 67b1e0df..7f1352c3 100644 --- a/README.qmd +++ b/README.qmd @@ -18,7 +18,7 @@ knitr::opts_chunk$set( [![R-CMD-check](https://github.com/UCD-SERG/serocalculator/actions/workflows/R-CMD-check.yaml/badge.svg)](https://github.com/UCD-SERG/serocalculator/actions/workflows/R-CMD-check.yaml) -[![codecov](https://codecov.io/gh/UCD-SERG/serocalculator/graph/badge.svg?token=85CXV6GN2T)](https://codecov.io/gh/UCD-SERG/serocalculator) +[![Codecov test coverage](https://codecov.io/gh/UCD-SERG/serocalculator/graph/badge.svg)](https://app.codecov.io/gh/UCD-SERG/serocalculator) ```{r svg} diff --git a/codecov.yml b/codecov.yml index 6907daec..fd6f67d0 100644 --- a/codecov.yml +++ b/codecov.yml @@ -1,14 +1,15 @@ coverage: status: - project: #add everything under here, more options at https://docs.codecov.com/docs/commit-status + project: # add everything under here, more options at + # https://docs.codecov.com/docs/commit-status default: # basic - target: auto #default + target: auto # default threshold: 1% base: auto - informational: true + informational: false # default patch: default: target: auto threshold: 1% - informational: true + informational: false diff --git a/inst/WORDLIST b/inst/WORDLIST index 2fa7f8f6..265e4144 100644 --- a/inst/WORDLIST +++ b/inst/WORDLIST @@ -8,6 +8,7 @@ CMD Campylobacter Ceper Chiang +Codecov De Dhulikhel Diekmann @@ -17,6 +18,7 @@ FIC Falkenhorst Fogarty Friesema +GHA Gageldonk Graaf Gras