Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

crossover to same helix should be converted properly in cadnano import #209

Closed
dave-doty opened this issue Jan 12, 2022 · 1 comment
Closed
Assignees
Labels
bug Something isn't working closed in dev high priority Something cruicial to get working soon.

Comments

@dave-doty
Copy link
Member

In cadnano 2, create a strand with two domains on the same helix and a "crossover" between them:

image

This should be representable in scadnano and show up like this:

image

Import this design into scadnano. Instead, it interprets the two domains and the crossover as one long domain:

image

This cadnano file represents the above simple design, to help reproduce this error.

@dave-doty dave-doty added bug Something isn't working high priority Something cruicial to get working soon. labels Jan 12, 2022
@tcosmo
Copy link
Collaborator

tcosmo commented Feb 1, 2022

@dave-doty @UnHumbleBen

I have solved this issue with this PR: #214

It should not be complex to adapt in the Dart code as it was only the case to add one more case to the condition that decides whether or not to add a crossover (condition 2.) :

Screenshot 2022-02-01 at 17 54 02

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working closed in dev high priority Something cruicial to get working soon.
Projects
None yet
Development

No branches or pull requests

2 participants