Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Milestone #3 Feedback #36

Open
rainerlempert opened this issue Mar 5, 2019 · 1 comment
Open

Milestone #3 Feedback #36

rainerlempert opened this issue Mar 5, 2019 · 1 comment

Comments

@rainerlempert
Copy link

Great work team! Your package installs easily and all of your tests pass. A couple comments:

  • I couldn't get your vignette to work by calling browseVignettes(). Perhaps this thread might be of some help?
  • When I called pytest on v3 of explorePy all of your tests passed! Thanks for updating that.
  • It might be a good idea to add a bit to your function descriptions, including a couple of usage examples.
@rachelkriggs
Copy link
Collaborator

We have fixed the vignette and added usage examples within each function for both packages

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@rainerlempert @rachelkriggs