Feedback on Milestone #3

[rainerlempert]

Nice work! Your package is well organized work and all of your tests passed! Your functions work and are well documented. A few comments:

• I had trouble loading your package using devtools::install_github("UBC-MDS/InstaRF") partially because you do not have install.packages() calls for dependencies inside your package. For example, loading failed because I did not previously have the packages spatialfil or png installed. I was able to install this manually, but in the future its good practice to include and install.packages(), or devtools:: call when using third party packages. It is often good practice to include dependencies in the DESCRIPTION file and the NAMESPACE file (see here.
• I was not able to load your vignette using browseVignettes("InstaRF"). Please update this for your final project. This thread may be instructive
• I reran your python tests and they all passed! Thank you for fixing that issue
• Very small issue, but I'm not sure why you have two image folders, one inside your tests folder and the other inside that in the testthat folder.