Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Address feedback to improve the package #52

Closed
colombe-tolokin opened this issue Jan 27, 2025 · 7 comments
Closed

Address feedback to improve the package #52

colombe-tolokin opened this issue Jan 27, 2025 · 7 comments
Assignees
Labels
bug Something isn't working documentation Improvements or additions to documentation enhancement New feature or request
Milestone

Comments

@colombe-tolokin
Copy link
Collaborator

No description provided.

@TinLattNandar
Copy link
Collaborator

TinLattNandar commented Jan 29, 2025

Milestone 2

@TinLattNandar
Copy link
Collaborator

TinLattNandar commented Jan 29, 2025

Feedback from Michael Suriawan

  • Rename Package name (done by Adrian)
  • Add explicit URL that points to your readthedocs page in the README @adrianl726
  • Add typings in all functions (both definitions and README)@adrianl726
  • Update extract_keyword function @TinLattNandar
  • Add target audience in README @colombe-tolokin

Reminder:

@QuanhuaHuang-ubc
Copy link
Collaborator

QuanhuaHuang-ubc commented Jan 29, 2025

Peer Review Feedback from Le Phi Long Nguyen:

Reminder:

@adrianl726 adrianl726 added this to the Milestone 4 milestone Jan 30, 2025
@adrianl726 adrianl726 added bug Something isn't working documentation Improvements or additions to documentation enhancement New feature or request labels Jan 30, 2025
@adrianl726
Copy link
Collaborator

adrianl726 commented Jan 30, 2025

Feedback from Dominic:

  • The introduction is somewhat redundant (the first two sentences repeat similar ideas), can be combined into one, i.e. "messageanalyzer is a powerful Python package designed for performing comprehensive..." @adrianl726
  • The descriptions of the Usage section are good, but they don’t indicate return values clearly. @colombe-tolokin
  • The second paragraph of the "Ecosystem Fit" section, refers to TextAnalyzer, which seems to be a naming inconsistency (probably should be messageanalyzer). @adrianl726
  • “Check out the contributing guidelines” does not provide a link. Add a direct link to the contributing guide would be beneficial. @colombe-tolokin

Reminder:

@adrianl726
Copy link
Collaborator

adrianl726 commented Jan 31, 2025

Feedback from Lixuan Lin:

  • The ci-cd workflow is not completely working now, I saw the cd job was skipped, which might be related to the semantic versioning not working properly. The semantic versioning only recognizes commit messages starting with keywords like "feat", "docs", "fix", etc. You can try this to run through the cd job. @adrianl726
  • Continuous integration and test coverage badges are recommended to add per Daniel's suggestions, you can consider adding these two in the README. @adrianl726
  • The docstring style of the functions is not consistent, some have the example section but some don't. (Same as ms2 feedback)
  • The test py files don't have docstring inside, you can consider add some.
  • I noticed a environment.yml file in the root directory, which includes many dependencies. This may cause conflicts with poetry. Only a python version would be enough here in this yml file. (remove yml) @QuanhuaHuang-ubc

Reminder:

@adrianl726 adrianl726 pinned this issue Jan 31, 2025
@QuanhuaHuang-ubc
Copy link
Collaborator

Peer Review Link: UBC-MDS/software-review-2025#24

@adrianl726
Copy link
Collaborator

adrianl726 commented Feb 1, 2025

Extra:

  • Changelog: Manually fix the "Feedback addressed by reviewer" t o "Feedback addressed by team" @TinLattNandar

@adrianl726 adrianl726 moved this from Todo to Done in DSCI524_Text_Analyzer_19 Feb 3, 2025
@adrianl726 adrianl726 closed this as completed by moving to Done in DSCI524_Text_Analyzer_19 Feb 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working documentation Improvements or additions to documentation enhancement New feature or request
Projects
Status: Done
Development

No branches or pull requests

4 participants