Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Milestone and Peer Feedbacks Addressed #49

Open
Piloxita opened this issue Jan 30, 2025 · 3 comments
Open

Milestone and Peer Feedbacks Addressed #49

Piloxita opened this issue Jan 30, 2025 · 3 comments
Assignees
@jenson-chang @gunishakaur @Piloxita @hanwang205
Milestone
Milestone 4

Comments

@Piloxita
Copy link
Collaborator

Long:
@Piloxita Piloxita added this to the Milestone 4 milestone Jan 30, 2025
@Piloxita Piloxita moved this to In Progress in 524 ClassifierProMax Project Jan 30, 2025
@Piloxita Piloxita changed the title Changes Have Been Addressed Issues Have Been Addressed Jan 30, 2025
@hanwang205
Copy link
Collaborator

@jenson-chang
Copy link
Collaborator

Milestone 2 feedback:

Peer feedback:

  • Readme improvements
    • Added test instructions for developers
    • Highlighted python 3.12 as a requirement before installation
    • Added links to CONTRIBUTING.md and LICENSE
    • Added reference to example.ipynb for users that want more tutorial information

@gunishakaur
Copy link
Collaborator

gunishakaur commented Jan 31, 2025 •
edited
Loading

Milestone 2 feedback:
Added extra parameters and thresholds in test function in feature selector
Updated docstring for test function- feature selector

@jenson-chang jenson-chang changed the title Issues Have Been Addressed Milestone and Peer Feedbacks Addressed Jan 31, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jenson-chang jenson-chang

@gunishakaur gunishakaur

@Piloxita Piloxita

@hanwang205 hanwang205

Labels
None yet
Projects
524 ClassifierProMax Project
Status: In Progress
Milestone
Milestone 4
Development

No branches or pull requests
4 participants
@jenson-chang @gunishakaur @Piloxita @hanwang205