-
Notifications
You must be signed in to change notification settings - Fork 712
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rendering of the navigation pane on iPad is shifted down #2191
Comments
I don't have an iPad suitable for troubleshooting this - PR welcome |
I have the iPad, but I don't have a CSS knowledge suitable for troubleshooting this. :-( If someone can suggest a fix, I can test it. |
Another question: are those large spaces between Setting, Modules and the list really necessary? |
I just checked and the issue can be also reproduced using an iPad simulator. Just be sure you select a 4th or 5th generation iPad (9.7", 2048x1536) and landscape screen orientation. Interestingly enough, on larger iPads I could not reproduce the issue. |
It's because certain iPads have the precise display dimensions (a computed width of 1024px) that would cause this edge case. My PR should resolve the top margin as well as the large spacing. Thanks for pointing it out. |
Does this also apply to a 9.7" screen with 2048x1536? |
Yeah. iOS devices, among others, have what's called a device pixel ratio. Although it has 2048 physical pixels across, that'd be illegible on a 9.7" display, so it presents browsers a width of 1024px and uses the pixels in between for stuff like finer font rendering; what Apple calls "retina". |
Thank you @futurGH for the explanation. So, if you think that this fix also applies to my iPad, and there is no need to test anything now, I'll wait for the next release. |
I noticed a small problem with rendering the generated site on an iPad: the navigation pane seems shifted down and the last link is not visible:
When rendered with Safari on macOS, it is ok:
The site was generated with 0.23.25.
The text was updated successfully, but these errors were encountered: