New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

REPL error context logged for all REPL errors; vanilla node logs only for SyntaxErrors #1576

Open

cspotcode opened this issue Dec 27, 2021 · 0 comments

Collaborator

cspotcode commented Dec 27, 2021 •

edited

Loading

Vanilla node REPL logs line context only for SyntaxErrors. For example:

$ node
Welcome to Node.js v17.0.0.
Type ".help" for more information.
> foo bar
foo bar           <-- this is the "context" I'm talking about
    ^^^

Uncaught SyntaxError: Unexpected identifier
>

We log for all errors.

Should we re-align with node in this regard?
Would likely require a change to cspotcode/node-source-map-support.

This PR highlights the relevant code in node core: nodejs/node#29676

The text was updated successfully, but these errors were encountered:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment