strictNullChecks can cause failures

[nevir]

It appears like ts-loader causes the TS compiler to parse .d.ts files in a different mode than what the compiler normally does?

From a working ts-loader based project (occurs on both webpack 1 & 2), on typescript 2.1:

1. Set "strictNullChecks": true"
2. Import a module that has a function that is declared with an optional options argument that is also destructured. In my case, that's apollo-client's constructor.

Running ./node_modules/.bin/tsc directly compiles without complaint. Running ts-loader results in:

ERROR in /node_modules/apollo-client/lib/src/ApolloClient.d.ts
(28,18): error TS2459: Type '{ networkInterface?: NetworkInterface | undefined; reduxRootKey?: string | undefined; reduxRootSe...' has no property 'networkInterface' and no string index signature.
…

Here's the complete tsconfig.json being used, as well:

{
  "compilerOptions": {
    "charset": "utf-8",
    "experimentalDecorators": true,
    "forceConsistentCasingInFileNames": true,
    "importHelpers": true,
    "jsx": "react",
    "module": "commonjs",
    "newLine": "LF",
    "noFallthroughCasesInSwitch": true,
    "noImplicitAny": true,
    "noImplicitReturns": true,
    "noUnusedParameters": true,
    "noUnusedLocals": true,
    "outDir": "./dist/",
    "pretty": true,
    "strictNullChecks": true,
    "target": "es5",
    "lib": [
      "dom",
      "es2016",
      "es2017.object"
    ],
    "sourceMap": true
  },
  "exclude": [
    "dist",
    "build",
    "node_modules"
  ]
}

Possibly related to microsoft/TypeScript#8681

[johnnyreilly]

Thanks for the detailed report; that's always appreciated. If you have ideas on how to remedy this we always welcome PRs.

[stale]

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

[stale]

Closing as stale. Please reopen if you'd like to work on this further.