Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

@djcsdy Yep, anyway we can improve perf more, we don't need to rewrite it for all extensions https://github.com/softwareventures/resolve-typescript-plugin/blob/main/index.ts#L28, only for ts/cts/mts, so we can add test regexp check, you try to solve it using node_modules regexp because most of js inside there, but JS can be not only in node_modules #1404

Closed
djcsdy opened this issue Jan 16, 2022 · 1 comment

Comments

@djcsdy
Copy link

djcsdy commented Jan 16, 2022

@djcsdy Yep, anyway we can improve perf more, we don't need to rewrite it for all extensions https://github.com/softwareventures/resolve-typescript-plugin/blob/main/index.ts#L28, only for ts/cts/mts, so we can add test regexp check, you try to solve it using node_modules regexp because most of js inside there, but JS can be not only in node_modules

You register two hooks https://github.com/softwareventures/resolve-typescript-plugin/blob/main/index.ts#L24, it can be bad for perf if you have a lot of ts files, better to improve regexp and use only one hook

Originally posted by @alexander-akait in #1383 (comment)

@djcsdy djcsdy closed this as completed Jan 16, 2022
@djcsdy
Copy link
Author

djcsdy commented Jan 16, 2022

Sorry, misclick!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant