Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update fails on windows if you have two atom windows open #195

Closed
basarat opened this issue Mar 19, 2015 · 3 comments
Closed

Update fails on windows if you have two atom windows open #195

basarat opened this issue Mar 19, 2015 · 3 comments

Comments

@basarat
Copy link
Member

basarat commented Mar 19, 2015

If you have two atom windows only the one where you are updating deactivates the package (and therefore stops the worker, needed to allow a file system unlink).

This is not an issue if only a single atom window is open when you run an update.

Workaround

Always update with just one atom window open.
However if you are in a bad state workaround is to uninstall / reinstall the package.

Steps to reproduce

On windows run:

apm install atom-typescript@1.3.1

and then open two atom windows and run update in one of them.

Related

#190

@basarat
Copy link
Member Author

basarat commented Mar 19, 2015

You can see a demo. ts worker sucessfully stopped only appears in the front window. This means its still running the background window and hence cannot be unlinked / deleted.

image

@nycdotnet
Copy link
Contributor

@basarat Do you think something like https://www.npmjs.com/package/ps-node would help us know if there were multiple copies of atom running? If so, do you know if there is a way to block or defer an update of a package until certain conditions are true? I would be willing to look implement this as I constantly have several instances of Atom open.

@basarat
Copy link
Member Author

basarat commented Sep 5, 2015

do you know if there is a way to block or defer an update of a package until certain conditions are true

Nope. And I suspect the atom team would be unwilling for packages to take such control. Best if someone fixes atom ... to call disable package on all open instances atom/atom#6032

I just opened the bug and saw it says needs reproduction perhaps they are waiting on that. Pretty easy to do ... one just needs to create a package that has a log message on package deactivate and show that its isn't called in all windows.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants