Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename "modules" to "namespaces" #109

Closed
sebastian-lenz opened this issue Jul 7, 2015 · 9 comments · Fixed by dbartholomae/redux-dynamic-modules-beacon#25 or gpicron/ssb-subjective-group#1
Labels
enhancement Improved functionality
Milestone

Comments

@sebastian-lenz
Copy link
Member

Starting with TypeScript 1.5 we have namespaces that will/should replace modules, see here. I would like to rename the documentation output accordingly as I always struggled with the distinction between "modules" and "external modules".

Old name New name
Module Namespace
External module Module

This would break existing urls and might interfere with other things but I think it's worth the trouble. Any opinions on this?

@sebastian-lenz sebastian-lenz added the enhancement Improved functionality label Jul 7, 2015
@indus
Copy link

indus commented Jul 22, 2015

👍

1 similar comment
@bd82
Copy link

bd82 commented Jul 24, 2015

👍

@aciccarello
Copy link
Collaborator

I'd like this, but we don't have many links to our docs to break.

@jasongrout
Copy link

+1

1 similar comment
@Chowarmaan
Copy link

👍

@aleung
Copy link

aleung commented Jan 26, 2016

Please rename it.
"External Module" is very confusing.

@MatthieuLebigre
Copy link

+1

@aciccarello
Copy link
Collaborator

This seems like low hanging fruit. The solution should have a way for projects to avoid breaking existing links. Text and URL changes could be completed as separate PRs

@Gerrit0 Gerrit0 removed the good first issue Easier issue for first time contributors label Jan 3, 2020
@Gerrit0
Copy link
Collaborator

Gerrit0 commented Jan 3, 2020

This might be low hanging fruit to someone familiar with the codebase, but there's a lot of potential for breakage in unexpected places from what I've seen with some experimenting with this last week. If you want to give this a shot, feel free, but I wouldn't say it's the easiest issue wanting help.

@Gerrit0 Gerrit0 modified the milestones: 1.0.0, 0.17 Jan 18, 2020
Gerrit0 added a commit that referenced this issue Jan 18, 2020
BREAKING CHANGE: Renames external modules to modules, and modules to namespaces. Closes #109.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment