Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pet Support? #8

Open
paige404 opened this issue Oct 26, 2021 · 3 comments
Open

Pet Support? #8

paige404 opened this issue Oct 26, 2021 · 3 comments

Comments

@paige404
Copy link

I'm loving this addon but as I play more with BST I can't help wishing it supported pet display. I looked first into trying to rig xivpetbar to stylistically match xivparty, but it's pretty janky. So then I started digging into xivparty to work at pet support from the other end and noticed that you already have the monster job icon in there that I was about to add.

Is pet support in and I just missed a feature I need to turn on somewhere? Or is assets/jobIcons/mon.png leftover from a partial implementation of this?

@Tylas11
Copy link
Owner

Tylas11 commented Oct 26, 2021

That icon is for monstrosity, where "mon" is the official abbreviation for the monipulator job. Pets are currently not supported, but I do have it on my long term feature request list. However I cannot make any promises when or if I will implement it.

There is a fork of xivparty which included pet support in an older version, but it doesnt seem to be maintained.

@paige404
Copy link
Author

Oh rad. I'll take a look at the changes they made and see if I can draft up a PR if it's all working well on mine.

@paige404
Copy link
Author

paige404 commented Nov 1, 2021

I did a bunch of BST leveling and unlocked SMN and PUP to test that fork, and it nearly all works. Just needs some tweaks to better support charm pets, and some cleanup on the UI so it doesn't have empty party slots on pet jobs.

Now that I know what their commit does and doesn't do, I'll start working on adapting it to the current codebase (a lot has changed I see). Then can work on getting charm pets working (gonna look into what xivpetbar does for that) and deal with empty party list slot if that continues to be an issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants