next and prev rel links in head should detect https

[MaluNoPeleke]

I have added a SSL certificate to my Ghost blog and noticed, that the next and prev rel links in head won't use https for links but every other link does.
You can check it live on https://www.peleke.de vs. http://www.peleke.de

Ghost 0.5.2
See bug #685

[jillesme]

I'll take this one on!

[jillesme]

@MaluNoPeleke have you updated your ghost config URL to use https too?

[novaugust]

Yeah, looking into the code, prev and next already use SSL - provided you've set the urlSSL option in config.js. See this blog post for an example.

You can also define your plain "url" to use "https", which would also take care of the issue.

[novaugust]

Right, I've done a bit more digging around and it looks like that is indeed the solution, and I don't see anything code-wise that needs changing. Going to close this for now, @MaluNoPeleke by all means come back if it doesn't fix your problem and we'll keep digging =)

[novaugust]

Reopening per @sebgie's comment:

I saw your discussion about urlSSL from earlier. The intention was to have a separate URL for SSL which is needed for environments like heroku. For example url: http://mydomain.com, urlSSL: https://secure.mydomain.com. Next/prev should have the correct URLs without explicitly setting urlSSL.

[MaluNoPeleke]

I have set the url parameter to http and the urlssl parameter to https and every other link except the prev/next links change accordingly.

[ErisDS]

It seems like this might be to do with secure not getting passed around properly. Possibly not quite as beginner as I thought.

I think @jillesme's PR was looking in the right direction but the signature for the method urlFor needs to be updated to take a secure parameter, just like the method createUrl.

I think the 3 lines that look like this: https://github.com/TryGhost/Ghost/blob/master/core/server/config/url.js#L129 also need to be updated. When using the urlFor method in the helper file the value of secure that gets set as a
res.local here should be available to pass through.

@jillesme would you be up for taking another stab at this?

[jillesme]

Yes definitely ! 

[sebgie]

@jillesme the PR looks good to me. Unfortunately this PR has fallen a bit behind and would need a rebase. Are you around to do a quick rebase?