-
-
Notifications
You must be signed in to change notification settings - Fork 10.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[features] A health check endpoint #11181
Comments
Hey @lzhuor 👋 Friendly reminder: we don't track feature requests on GitHub. Please look for similar ideas to vote for on the forum and if you can't anything similar then post your own idea. FYI: Many projects have their own support guidelines and GitHub will highlight them for you as it did here, or the project owners will use issue templates to point you in the right direction. Reading the guidelines or issue templates before opening issues can save you and project maintainers valuable time. |
Reopening |
Really? No healthcheck endpoint? Seriously? |
@lzhuor you said "Reopening" but you never reopened it. |
Having issues with a restarting container on ECS. Root gives me a 302 which is considered unhealthy. Ghost needs a healthcheck endpoint to keep up with modern deployment strategies... |
If you need a 200 that isn't cached you can hit an API endpoint. |
Looks good. But how could I have possibly found this in the docs? There should be a |
Not having a health check route seems to make Ghost impossible to run behind a load balancer if you need https enabled. |
I totally agree, that's a total mess to make such a simple thing. I see 3 things here:
I'm working on a Kubernetes environment, here is an example how you can set the healthchecks on your blog deployment:
Hope it helps ❤️ PS: thanks @jakubgs for pointing out the right URL to use 😃 |
The There's a PR open to address this issue here: #13117 but as I've mentioned here, the thing that held me back from merging it is the lack of precedent and it also doesn't seem to really solve the problem above and beyond the I'm more than happy to merge a PR that has a well thought out and evidenced solution for this :) |
|
Of note: with ghost v5, it should be /ghost/api/admin/site, and not /ghost/api/v3/admin/site (or anything that's versioned). |
And @debugger22, you can bypass it by passing in the |
Could we please add a simple health api in
index.js
?It will serve our needs for load balancers (GCP for us), site reliability monitoring. I am creating a PR for it but seeking for your advice in advance.
The text was updated successfully, but these errors were encountered: