Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure get_last_line_of_set_of_lines() function works correctly and is tested properly. #71

Open
a-t-0 opened this issue Feb 13, 2022 · 0 comments
Labels
bug Something isn't working good first issue Good for newcomers help wanted Extra attention is needed

Comments

@a-t-0
Copy link
Member

a-t-0 commented Feb 13, 2022

In file helper_parsing.sh, one can find get_last_line_of_set_of_lines, however the following test from test_parsing.bats fails on it:

@test "Last line is returned correctly." {
	# TODO: determine why this test does not work.
	#lines=$(printf 'First line\nsecond line \nthird line \nsometoken')
	
	#local actual_result=$(get_last_line_of_set_of_lines "${EXAMPLE_LINES}")
	local actual_result=$(get_last_line_of_set_of_lines $EXAMPLE_LINES)
	local expected_output="sometoken"
		
	assert_equal "$actual_result" "$expected_output"
}
@a-t-0 a-t-0 added bug Something isn't working good first issue Good for newcomers help wanted Extra attention is needed labels Feb 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working good first issue Good for newcomers help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

1 participant