Skip to content

Commit 852a1a6

Browse files
build: avoid compiling with VS v17.10
Refs: nodejs/build#3739 PR-URL: nodejs#53863 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> Reviewed-By: Gerhard Stöbich <deb2001-github@yahoo.de>
1 parent 8027a7b commit 852a1a6

File tree

1 file changed

+8
-0
lines changed

1 file changed

+8
-0
lines changed

vcbuild.bat

+8
Original file line numberDiff line numberDiff line change
@@ -283,6 +283,14 @@ goto exit
283283

284284
:msbuild-found
285285

286+
@rem Visual Studio v17.10 has a bug that causes the build to fail.
287+
@rem Check if the version is v17.10 and exit if it is.
288+
echo %VSCMD_VER% | findstr /b /c:"17.10" >nul
289+
if %errorlevel% neq 1 (
290+
echo Node.js doesn't compile with Visual Studio 17.10 Please use a different version.
291+
goto exit
292+
)
293+
286294
@rem check if the clang-cl build is requested
287295
if not defined clang_cl goto clang-skip
288296
@rem x64 is hard coded as it is used for both cross and native compilation.

0 commit comments

Comments
 (0)