From 7296973d3c4bce7cc4a7344a66de6dd0d0a7eb4e Mon Sep 17 00:00:00 2001 From: Rich Trott Date: Sat, 2 Jun 2018 09:25:23 +0200 Subject: [PATCH] test: remove postmortem test from flaky list MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit test-postmortem-metadata does not ever seem to fail on master. According to Michaël Zasso, when it fails locally for him during a V8 upgrade, he pings Colin Ihrig who fixes it almost immediately. There was some discussion about marking it flaky when it first landed but it's not clear to me that it is necessary. (We can always mark it flaky again if it turns out that it is necessary.) The reason I want this test removed from the status file for flaky tests is that I believe that file can and should be used as a list of tests to fix. But this test doesn't need any fixing. Refs: https://github.com/nodejs/node/pull/17685 --- test/parallel/parallel.status | 2 -- 1 file changed, 2 deletions(-) diff --git a/test/parallel/parallel.status b/test/parallel/parallel.status index e4b757bbd3dac9..f79a3b149a8edc 100644 --- a/test/parallel/parallel.status +++ b/test/parallel/parallel.status @@ -5,8 +5,6 @@ prefix parallel # sample-test : PASS,FLAKY [true] # This section applies to all platforms -# Postmortem debugging data is prone to accidental removal during V8 updates. -test-postmortem-metadata: PASS,FLAKY [$system==win32] test-child-process-fork-net: PASS,FLAKY