Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

occasionally prove the correct execution of the TASM snippets #3

Open
jan-ferdinand opened this issue Dec 19, 2022 · 2 comments
Open
Assignees
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@jan-ferdinand
Copy link
Member

Writing a bunch of TASM gives us the opportunity to test Triton VM more rigorously. I suggest to write tests that are

  • ignored by default, but
  • run occassionally
    where all TASM snippets are thrown into Triton VM and their correct execution proven.
@jan-ferdinand jan-ferdinand added enhancement New feature or request good first issue Good for newcomers labels Dec 19, 2022
@Sword-Smith
Copy link
Contributor

We could do this with an environment variable, only running the prover and verifier when a specific environment variable was set.

@jan-ferdinand
Copy link
Member Author

jan-ferdinand commented Feb 9, 2023

It's possible to stay entirely within the rust ecosystem. Properly named tests, .e.g., tests including the substring prove_verify in their name, adding the #[ignore] tag to those tests, and then occasionally running cargo test prove_verify --ignored does the trick.

What's harder to decide is what “occasionally” means, who's responsibility it is to run those tests on schedule (if there is one), et cetera.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

3 participants