Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cata Classic - 4.4.1.58158 dump bigger than expect and extreme slow parsing? #913

Open
TheSCREWEDSoftware opened this issue Jan 12, 2025 · 6 comments

Comments

@TheSCREWEDSoftware
Copy link

TheSCREWEDSoftware commented Jan 12, 2025

I just did a run on 3 different clients and the difference of size was quite difference.

Vanilla and Cata were from Orgri (entrance) to each zepplin (vanilla outside, cata on top of orgri) to tristafal and walked (vanilla) and mounted (cata) to scarlet monastery (armory).

And retail was from dornagal to orgri to undercity portal (which took me at back in time npc outside of undercity) and i flew with dragon riding to scarlet monastery (which has the old armory dont recall the name now).

To in the end get to the end of the dungeon and interact with the plaques in.

Some how retail which loaded more information and gather more in theory than the other two. retail and vanilla had almost 1MB of difference in size (2MB (Vanilla) to 2.9MB (Retail)) and Cata had 7MBs and was taking much longer than the other two. (this data non-parsed)

Average time for vanilla and cata was 10 ish (cata was more like 8) mins and retail was 5 if not less.

If this is a intended behaviour be free to close this.

@Ovahlord
Copy link
Contributor

This is because of hotfixes.

@killerwife
Copy link
Collaborator

Its also because shaurens parsing on retail works perfectly, and mine on vanilla is shoddy at best. Its especially visible on 3.4.3 parsing incredibly quickly without exceptions, and 3.4.1 and 3.4.2 being pretty crap cos i only did a makeshift solution for most important packets.

@TheSCREWEDSoftware
Copy link
Author

Thanks for the clarification. I pressume the ones that are working (for cata) in this case are aware of this? if it's the case is worth keeping the issue opened?

@Ovahlord
Copy link
Contributor

Cata Classic parses just fine

@TheSCREWEDSoftware
Copy link
Author

It parsed the file fine. The question should If keep my issue opened as my oriignal question was answered. (related to the size difference and longer parsering) in the case if is not known to the maintainers of this case cata parser part of it.

@Ovahlord
Copy link
Contributor

Ovahlord commented Jan 13, 2025

Keep it open for now.
The cata parsing is currently broken as a result of the recently added 1.15 changes which apparently were untested for 4.4.x. This will eventually get fixed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants