You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
We have had, have, and will have PRs with conflicts between an author and a reviewer. Although it is preferable to find a consensus by the parties alone (by following the Google Gude Book for example), it is not always possible.
To resolve conflicts like this we collectively agreed (@synctext, @xoriole, @egbertbouman, @kozlovsky, @drew2a) to introduce a Tie Breaker mechanism which will follow: in the case of disagreement between the PR author and a reviewer, the PR author or reviewer could ask for a second opinion from a randomly chosen developer (tie breaker); the decision from the tie breaker is the final decision in the dispute, and both parties should adhere to it.
To implement the mechanism, I propose creating a GitHub Action that reacts to a specific comment (like 'second opinion', 'tie breaker', or suggest yours) and adds a randomly chosen developer from the Tribler Reviewers Team as a reviewer for the PR. The Tie Breaker should provide their resolution for the conflict situation.
Another way to trigger the action is to add a specific label to the PR (like 'conflict', 'need a resolution', 'tie breaker').
Please comment on the idea itself and the way it should be implemented (GitHub actions or not? Comment or label? etc.).
The text was updated successfully, but these errors were encountered:
We have had, have, and will have PRs with conflicts between an author and a reviewer. Although it is preferable to find a consensus by the parties alone (by following the Google Gude Book for example), it is not always possible.
An example: #7764 (comment)
To resolve conflicts like this we collectively agreed (@synctext, @xoriole, @egbertbouman, @kozlovsky, @drew2a) to introduce a Tie Breaker mechanism which will follow: in the case of disagreement between the PR author and a reviewer, the PR author or reviewer could ask for a second opinion from a randomly chosen developer (tie breaker); the decision from the tie breaker is the final decision in the dispute, and both parties should adhere to it.
To implement the mechanism, I propose creating a GitHub Action that reacts to a specific comment (like 'second opinion', 'tie breaker', or suggest yours) and adds a randomly chosen developer from the Tribler Reviewers Team as a reviewer for the PR. The Tie Breaker should provide their resolution for the conflict situation.
Another way to trigger the action is to add a specific label to the PR (like 'conflict', 'need a resolution', 'tie breaker').
Please comment on the idea itself and the way it should be implemented (GitHub actions or not? Comment or label? etc.).
The text was updated successfully, but these errors were encountered: