Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add info about stopped/finished downloads in logs #6843

Closed
setaur opened this issue Apr 2, 2022 · 2 comments · Fixed by #6867
Closed

Add info about stopped/finished downloads in logs #6843

setaur opened this issue Apr 2, 2022 · 2 comments · Fixed by #6867
Assignees
Milestone

Comments

@setaur
Copy link

setaur commented Apr 2, 2022

Is your feature request related to a problem? Please describe.
I'm trying to build some kind of notification script (via telegram/email) for when a download is finished. If #2901 was finally introduced, that wouldn't be a problem, but without it I have to improvise something else.

Describe the solution you'd like
It would be very useful for me to have information about the finished download in the logs. When download is started there is a line in the logs, e.g.:

INFO:DownloadManager:Start handle. Download: Download <name: 'b'debian-11.2.0-amd64-DVD-1.iso'' hops: 0 checkpoint_disabled: 0>. Atp: {'save_path': '/home/bart/TriblerDownloads', 'storage_mode': libtorrent.storage_mode_t.storage_mode_sparse, 'flags': 208, 'ti': <libtorrent.torrent_info object at 0x7ffa5855c0f0>, 'resume_data': b'd11:file-format22:libtorrent resume file12:file-versioni1e9:info-hash20:\xc9\xa37V,\xb06\x0f\xd6\xf5\xab@\xfd+\x1b\x81\xd52]\xbde'}

But when download is finished, there is none indication about it in the logs. I don't think it would be a big burden to implement something like this? :)

@drew2a drew2a self-assigned this Apr 12, 2022
@drew2a drew2a added this to the 7.13.0 April milestone Apr 12, 2022
@drew2a
Copy link
Contributor

drew2a commented Apr 13, 2022

@setaur a PR with the requested feature will be merged soon.

Please take a look at the output:

INFO - Download(257) - On state changed alert: ubuntu-14.10-server-i386.iso: state changed to: finished
INFO - Download(408) - On torrent finished alert: ubuntu-14.10-server-i386.iso torrent finished downloading
INFO - Download(257) - On state changed alert: ubuntu-14.10-server-i386.iso: state changed to: seeding
INFO - Download(276) - On save resume data alert: ubuntu-14.10-server-i386.iso resume data generated.

@setaur
Copy link
Author

setaur commented Apr 13, 2022

Yeah, that would work great for me. Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging a pull request may close this issue.

2 participants