Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug in the code? #73

Open
hzhz2020 opened this issue Sep 1, 2023 · 0 comments
Open

Bug in the code? #73

hzhz2020 opened this issue Sep 1, 2023 · 0 comments

Comments

@hzhz2020
Copy link

hzhz2020 commented Sep 1, 2023

Hi
Thank you for this amazing repo.
For the implementation of FlexMatch. you update the selected_label in this line selected_label[x_ulb_idx[select == 1]] = pseudo_lb[select == 1]

selected_label[x_ulb_idx[select == 1]] = pseudo_lb[select == 1]

where the indicator variable 'select' is returned from this line select = max_probs.ge(p_cutoff).long() https://github.com/TorchSSL/TorchSSL/blob/f26e1d42967cec7f7c8a00c2e7ff9219d8ab7c92/models/flexmatch/flexmatch_utils.py#L46C9-L46C47

But this is not using the flexible threshold in the paper, this is the regular FixMatch threshold. Why did you only use the flexible threshold to calculate loss, but not selecting instance for updating the select_labee?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant