From 48b5252d00900b2dcac33add76aa97952adb8d9c Mon Sep 17 00:00:00 2001 From: Matt Carrick Date: Mon, 8 May 2023 12:21:44 -0400 Subject: [PATCH 1/2] excess bandwidth is defined in porportion to signal bandwidth, not sampling rate, thus needs to be scaled by the samples per symbol --- torchsig/datasets/synthetic.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/torchsig/datasets/synthetic.py b/torchsig/datasets/synthetic.py index 330c631..9ee49e2 100644 --- a/torchsig/datasets/synthetic.py +++ b/torchsig/datasets/synthetic.py @@ -367,7 +367,7 @@ def _generate_samples(self, item: Tuple) -> np.ndarray: ) zero_padded[:: self.iq_samples_per_symbol] = symbols pulse_shape_filter_length = estimate_filter_length( - signal_description.excess_bandwidth + signal_description.excess_bandwidth/self.iq_samples_per_symbol ) pulse_shape_filter_span = int( (pulse_shape_filter_length - 1) / 2 From 8a4227258c49d05ffffe9965619713964ffcfe65 Mon Sep 17 00:00:00 2001 From: Matt Carrick Date: Mon, 8 May 2023 12:22:56 -0400 Subject: [PATCH 2/2] filling in a comment to describe modification to code --- torchsig/datasets/synthetic.py | 2 ++ 1 file changed, 2 insertions(+) diff --git a/torchsig/datasets/synthetic.py b/torchsig/datasets/synthetic.py index 9ee49e2..daff017 100644 --- a/torchsig/datasets/synthetic.py +++ b/torchsig/datasets/synthetic.py @@ -366,6 +366,8 @@ def _generate_samples(self, item: Tuple) -> np.ndarray: (self.iq_samples_per_symbol * len(symbols),), dtype=np.complex64 ) zero_padded[:: self.iq_samples_per_symbol] = symbols + # excess bandwidth is defined in porportion to signal bandwidth, not sampling rate, + # thus needs to be scaled by the samples per symbol pulse_shape_filter_length = estimate_filter_length( signal_description.excess_bandwidth/self.iq_samples_per_symbol )