Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Installation instructions on README.md #56

Closed
akeapen opened this issue Apr 2, 2023 · 1 comment · Fixed by #57
Closed

Installation instructions on README.md #56

akeapen opened this issue Apr 2, 2023 · 1 comment · Fixed by #57

Comments

@akeapen
Copy link

akeapen commented Apr 2, 2023

Requires update README.md from:

cd torchsig
pip install -r requirements.txt
pip install .

to...

cd torchsig
pip install -e .

in order to conform to installing dependencies via pyproject.toml

@gvanhoy gvanhoy linked a pull request Apr 3, 2023 that will close this issue
@gvanhoy
Copy link
Collaborator

gvanhoy commented Apr 3, 2023

I don't think we want to encourage an editable install by default, but no longer needing to install the requirements in the old way should be removed -- thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants