Crash when sending very large message with debug on

[Steelight]

When using debug prints, sending long messages crashes. I made a change to FramedataImpl1.toString() to fix this:

    @Override
    public String toString() {
        String payload = null;
        if (unmaskedpayload.array().length < 200)
        {
            payload = Arrays.toString( Charsetfunctions.utf8Bytes( new String( unmaskedpayload.array() ) ) );
        }
        else
        {
            byte[] subArray = Arrays.copyOfRange(unmaskedpayload.array(), 0, 200);
            payload = Arrays.toString( Charsetfunctions.utf8Bytes( new String( subArray ) ) );
        }
        return "Framedata{ optcode:" + getOpcode() + ", fin:" + isFin() + ", payloadlength:" + unmaskedpayload.limit() + ", payload:" + payload + "}";
    }

200 should be replaced with a proper value/constant, of course.

[Davidiusdadi]

Interesting, does your VM crash or do you get some sort of Error/Exception?

[Steelight]

Out of memory exception, if I remember correctly.

[Davidiusdadi]

You should use the VM Xmx option to prevent this error.
The problem is not the toString method but the fact that your frames barely fit into memory.

You probably already know about Xmx but here is a link to that topic:

http://www.jafaloo.com/2011/10/30/java-xmx-memory-settings/

[Steelight]

Did I mention I'm running on Android? I'm not sure if there's a way to do this on Android. According to this:
http://tordtech.blogspot.co.il/2009/09/memory-limit-on-android.html
it will require changing the Android source code.

[Davidiusdadi]

An other way is not to use so much memory...

One think i wanted to do anyway is to allow to receive fragemented frames properly. Currently fragmented frames will be stored until all fragments of a frame are received and then delivered as one big frame. But receiving frames directly via an onFragment method would allow you to shrink the framebuffers size.

Would that help?

[Steelight]

Well, actually, I'm sending these ginormous packages. They are sent and received (on the remote side) properly, and the only problem is with the debug prints.

[Davidiusdadi]

I'd suggest that you disable the debug prints...

[Steelight]

Look, the problem is solved as far as I am concerned. If you want the fix, cool, if you don't, I'll just add it manually to future versions. I just wanted to share.