From ddccb946ff531d1b792623b55144320722d9e8bf Mon Sep 17 00:00:00 2001
From: Thomas Harte <thomas.harte@gmail.com>
Date: Tue, 25 Feb 2025 23:24:11 -0500
Subject: [PATCH] Fix precedence error in put_le.

---
 Storage/FileHolder.hpp | 13 +++++++------
 1 file changed, 7 insertions(+), 6 deletions(-)

diff --git a/Storage/FileHolder.hpp b/Storage/FileHolder.hpp
index d01e5f0d54..7cc35c78e0 100644
--- a/Storage/FileHolder.hpp
+++ b/Storage/FileHolder.hpp
@@ -52,7 +52,8 @@ class FileHolder final {
 	*/
 	template <typename IntT, size_t bytes = 0>
 	void put_le(IntT value) {
-		for(size_t c = 0; c < bytes ? bytes : sizeof(IntT); c++) {
+		constexpr auto size = bytes ? bytes : sizeof(IntT);
+		for(size_t c = 0; c < size; c++) {
 			put8(uint8_t(value));
 			value >>= 8;
 		}
@@ -75,11 +76,11 @@ class FileHolder final {
 	*/
 	template <typename IntT, size_t bytes = 0>
 	IntT get_le() {
-		constexpr auto length = bytes ? bytes : sizeof(IntT);
+		constexpr auto size = bytes ? bytes : sizeof(IntT);
 		IntT result{};
-		for(size_t c = 0; c < length; c++) {
+		for(size_t c = 0; c < size; c++) {
 			result >>= 8;
-			result |= IntT(get8() << ((length - 1) * 8));
+			result |= IntT(get8() << ((size - 1) * 8));
 		}
 		return result;
 	}
@@ -89,9 +90,9 @@ class FileHolder final {
 	*/
 	template <typename IntT, size_t bytes = 0>
 	IntT get_be() {
-		constexpr auto length = bytes ? bytes : sizeof(IntT);
+		constexpr auto size = bytes ? bytes : sizeof(IntT);
 		IntT result{};
-		for(size_t c = 0; c < length; c++) {
+		for(size_t c = 0; c < size; c++) {
 			result <<= 8;
 			result |= get8();
 		}